Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 KCP: cache unstructured #8913

Merged
merged 1 commit into from
Jun 26, 2023
Merged

🌱 KCP: cache unstructured #8913

merged 1 commit into from
Jun 26, 2023

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
In KCP we only ever use unstructured to get InfraMachine and InfraMachineTemplate. In both cases it absolutely does not matter if the object is stale:

  • We only use InfraMachine to:
    • check via the template annotations if we have to rollout. The annotations never change.
    • as original object before we apply labels/annotations. Doesn't matter if it is slightly stale there (we also use SSA)
  • We only use InfraMachineTemplate to set an ownerRef

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 26, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 26, 2023
@sbueringer
Copy link
Member Author

/assign @fabriziopandini @killianmuldoon @ykakarap

/hold
for
/test pull-cluster-api-e2e-full-main

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2023
@sbueringer sbueringer added the area/control-plane Issues or PRs related to control-plane lifecycle management label Jun 26, 2023
sbueringer
sbueringer commented Jun 26, 2023
View reviewed changes
controlplane/kubeadm/internal/controllers/controller.go
@@ -70,11 +70,11 @@ const (

// KubeadmControlPlaneReconciler reconciles a KubeadmControlPlane object.
type KubeadmControlPlaneReconciler struct {
Client client.Client
APIReader client.Reader
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APIReader was never read by production code (only tests) so I got rid of it

@sbueringer sbueringer mentioned this pull request Jun 26, 2023
Merged
@sbueringer
Copy link
Member Author

/hold cancel
e2e is green

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2023
@sbueringer
Copy link
Member Author

I'll also run some scale tests locally in addition to that. Please don't hold cancel

@sbueringer
KCP: cache unstructured
7fe546b 
Signed-off-by: Stefan Büringer [email protected]
@sbueringer sbueringer force-pushed the pr-kcp-cache-unstructured branch from 81386cb to 7fe546b Compare June 26, 2023 16:02
@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 7fe546b link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbueringer sbueringer mentioned this pull request Jun 23, 2023
Open
27 tasks
fabriziopandini
fabriziopandini reviewed Jun 26, 2023
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 51870f53339cd4b4bec98c7b981ae7c327c12316

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2023
@k8s-ci-robot k8s-ci-robot merged commit 09f07c5 into kubernetes-sigs:main Jun 26, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Jun 26, 2023
@sbueringer sbueringer deleted the pr-kcp-cache-unstructured branch June 26, 2023 19:21
@killianmuldoon
Copy link
Contributor

/area provider/control-plane-kubeadm

@k8s-ci-robot k8s-ci-robot added the area/provider/control-plane-kubeadm Issues or PRs related to KCP label Jun 27, 2023
@killianmuldoon killianmuldoon removed the area/control-plane Issues or PRs related to control-plane lifecycle management label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@ykakarap ykakarap Awaiting requested review from ykakarap

Assignees

@fabriziopandini fabriziopandini

@ykakarap ykakarap

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/control-plane-kubeadm Issues or PRs related to KCP cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
5 participants
@sbueringer @k8s-ci-robot @killianmuldoon @fabriziopandini @ykakarap